github / archive-program

The GitHub Archive Program & Arctic Code Vault
3.01k stars 248 forks source link

Change text direction in GUIDE_ar.md to RTL #95

Open mhalsubhi opened 4 years ago

mhalsubhi commented 4 years ago

The Arabic language is "RTL(Right-to-left)" language, so I change the direction of GUIDE_ar.md file to RTL by contain each element inside div with dir="rtl" attribute

j-f1 commented 4 years ago

I’m pretty sure browsers will automatically interpret Arabic text as right-to-left, even without an explicit dir=rtl attribute.

mhalsubhi commented 4 years ago

According to my understanding actually, it's not because the default value of dir attribute is ltr even if the browser's language is set to Arabic, the browser will set the correct direction automatically if the default value of dir is auto see this example

also, the issue it is becoming very hard to read when mixing Arabic and English here's how we read it before fix image

the blue arrows (number 3) it's difficult and uncomfortable to read

here's how we read it after fix image this is the comfortable and correct way we read Arabic mixed with English.