search

github / balanced-employee-ip-agreement

GitHub's employee intellectual property agreement, open sourced and reusable
Creative Commons Zero v1.0 Universal
2.14k stars 148 forks source link

Fix section number reference #37

Closed jessla closed 7 years ago

jessla commented 7 years ago

In Section 2 there's a reference to the "section above" but it refers to that section as Section 2 when it seems like it should be Section 1. From a quick glance the .pdf version also has this error.

mlinksva commented 7 years ago

@jessla thanks, you're right! How embarrassing. This is my fault, introduced in #33.

I wish we could get rid of the numbered reference altogether as it feels like it makes the text slightly more fragile for reuse, but that's just a wish. I'll plan on updating version and adding generated PDF and other documents to branch in a bit, then merging.

mlinksva commented 7 years ago

FYI I haven't merged this yet because I've noticed a couple other potential non-substantive copyedits that may be worth doing before bumping to v1.0.1.

mlinksva commented 7 years ago

Closing, commits incorporated into #44