reserved identifier violation

github / brubeck

A Statsd-compatible metrics aggregator

MIT License

1.19k stars 94 forks source link

reserved identifier violation #13

Closed elfring closed 9 years ago

elfring commented 9 years ago

I would like to point out that identifiers like "__BLOOM_FILTER_H" and "__BRUBECK__H_" do not fit to the expected naming convention of the C language standard. Would you like to adjust your selection for unique names?

vmg commented 9 years ago

Thanks, I think I'll pass on this one -- not too concerned about collisions here.

elfring commented 9 years ago

How do you think about to avoid that this software depends on undefined behaviour?