search

github / brubeck

A Statsd-compatible metrics aggregator
MIT License
1.19k stars 94 forks source link

Mac OS X Version patch file #39

Open deanbittner opened 8 years ago

deanbittner commented 8 years ago

Patch attached ... a bit rough but with a lot of road miles. mac_os_x.657498c47e0cabc6aaecc6e1b0db8b25e5c0be22.patch.txt

vmg commented 8 years ago

Hi! Thanks for your contribution. I'm afraid I cannot merge the patch because a lot of the workarounds for OSX compatibility affect negatively the design of the library (particularly, the workarounds for the lack of signalfd on OSX). :(

I'm gonna leave this open anyway in case somebody wants to run this patch on their own version.

deanbittner commented 8 years ago

That's about what I was thinking. I might get around to fixing it up ... It was just a really quick hack.

Cheers,

Dean

On May 4, 2016, at 3:09 AM, Vicent Marti notifications@github.com wrote:

Hi! Thanks for your contribution. I'm afraid I cannot merge the patch because a lot of the workarounds for OSX compatibility affect negatively the design of the library (particularly, the workarounds for the lack of signalfd on OSX). :(

I'm gonna leave this open anyway in case somebody wants to run this patch on their own version.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub