search

github / brubeck

A Statsd-compatible metrics aggregator
MIT License
1.19k stars 94 forks source link

Overflowing pickle write buffer as set in src/backends/carbon.h #48

Open deanbittner opened 8 years ago

deanbittner commented 8 years ago

The default setting --

define PICKLE_BUFFER_SIZE 4096

Is too small, at least for me. I overflow it. I've built with a larger buffer, 16384, and no issues after that. The observed symptom is that all metrics are not visible and present in whisper, Graphite and downstream when I overwrite this buffer.

vmg commented 8 years ago

I'm not sure I understand the issue here; the buffer is checked for capacity before pushing new pickles, so it should not be possible to overflow it. Can you provide a reproduction recipe?

deanbittner commented 8 years ago

Yes, I see that now ... I will take a closer look and see if I can get a test case going.