Open ryecroft opened 1 year ago
This is maybe related to #117, but not 100% sure on that.
With a component defined like this:
import { controller, attr } from '@github/catalyst' @controller class TestComponentElement extends HTMLElement { @attr get booleanProp() { return false } set booleanProp( _v: boolean ) { console.dir( `booleanProp type: ${ typeof _v }` ) console.dir( `booleanProp value: '${ _v }'` ) } connectedCallback() { this.booleanProp = true } }
and html like this (note the lack of an initial boolean-prop value):
boolean-prop
<test-component></test-component>
I get these log messages:
booleanProp type: boolean booleanProp value: 'true' booleanProp type: string booleanProp value: ''
Changing the html to include an initial value like this:
<test-component boolean-prop='anything'></test-component>
get's rid of that final empty string call:
booleanProp type: boolean booleanProp value: 'true'
Maybe this is a limitation? Hopefully this isn't another ghost bug, sorry about the last one 🫣
Thanks for the report! This is very helpful, it looks like a bug.
Would you like to submit a PR with a failing test case? That would be very helpful!
Hi Keith, no problem I'll do that soon
This is maybe related to #117, but not 100% sure on that.
With a component defined like this:
and html like this (note the lack of an initial
boolean-prop
value):I get these log messages:
Changing the html to include an initial value like this:
get's rid of that final empty string call:
Maybe this is a limitation? Hopefully this isn't another ghost bug, sorry about the last one 🫣