github / catalyst

Catalyst is a set of patterns and techniques for developing components within a complex application.
https://github.github.io/catalyst/
MIT License
1.36k stars 50 forks source link

Add failing test for default-valued properties #297

Open ryecroft opened 2 years ago

ryecroft commented 2 years ago

@attr properties with a default value (specified using a getter method) incorrectly have their setter method called with an empty string after setting the property in the connectedCallback

This incorrect behaviour does not happen if:

primer-css commented 2 years ago

:wave: Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

keithamus commented 1 year ago

Thanks for filing this @ryecroft. I'll be looking into this soon hopefully!