github / cleanowners

A GitHub Action to suggest removal of non-organization members from CODEOWNERS files

MIT License

109 stars 7 forks source link

fix: automated release short tag detection #54

Closed jmeridth closed 5 months ago

jmeridth commented 5 months ago

Pull Request

Proposed Changes

[x] was using a dash in the variable name, that's no bueno
- switched to underscore
[x] Also looks like we can't split auto-labeler and release-drafter configs.
- template key is required no matter what
[x] add call to create discussion about release in Announcements discussion
- won't be linked to the release unfortunately, feature missing from release-drafter
[x] fix mispelling in config issue template (GitHuB to GitHub)
[x] update pull request template with fix instead of bug

Readiness Checklist

Author/Contributor

[x] If documentation is needed for this change, has that been included in this pull request
[x] run make lint and fix any issues that you have introduced
[x] run make test and ensure you have test coverage for the lines you are introducing

Reviewer

[x] Label as either fix, documentation, enhancement, infrastructure, or breaking

jmeridth commented 5 months ago

auto labeler is going to fail until merged to default branch, unfortunately.