Closed jmeridth closed 6 months ago
@zkoppert how do you feel about fix
being a minor bump (aka causes a release)? Or do we want to batch after a few fixes and the PR we decide to release on, we manually add the release
label? 🤔
@zkoppert how do you feel about
fix
being a minor bump (aka causes a release)? Or do we want to batch after a few fixes and the PR we decide to release on, we manually add therelease
label? 🤔
To me, fix
means that we fixed a bug. Since we don't rate bugs by severity I'd prefer to get those bug fixes out the door (shipped) as soon as possible by cutting a release.
@zkoppert how do you feel about
fix
being a minor bump (aka causes a release)? Or do we want to batch after a few fixes and the PR we decide to release on, we manually add therelease
label? 🤔To me,
fix
means that we fixed a bug. Since we don't rate bugs by severity I'd prefer to get those bug fixes out the door (shipped) as soon as possible by cutting a release.
@zkoppert fix
moved in .github/release.yml
to minor semver bump. thank you for feedback.
Related to https://github.com/github/github-ospo/issues/105
Pull Request
Proposed Changes
Only generate a release and new action container images if our semver related labels (
breaking
,enhancement
,fix
) or therelease
label are used on a merged pull request.Changed from push (merge) on main branch to release generation happening when a pull_request is merged to main branch.
This gives us access to the pull requests labels without having to make API cals.
Currently we'd still need to label a pull request with
release
if it is a dependabot or manual pull request related to a CVE or security fix.vuln
andrelease
labels to repositoryReadiness Checklist
Author/Contributor
make lint
and fix any issues that you have introducedmake test
and ensure you have test coverage for the lines you are introducingReviewer
fix
,documentation
,enhancement
,infrastructure
,maintenance
orbreaking