search

github / codeql-action

Actions for running CodeQL analysis
MIT License
1.16k stars 323 forks source link

Do we need to run for TypeScript & JavaScript or only one? #1319

Closed oliviertassinari closed 2 years ago

oliviertassinari commented 2 years ago

In https://github.com/mui/mui-toolpad/blob/545dc0f332836a84248b1e53a47d3840846f7cf1/.github/workflows/codeql.yml#L7-L41 we are running CodeQL with javascript and typescript as a language, but in the running logs, it seems to output the same thing https://github.com/mui/mui-toolpad/actions/workflows/codeql.yml.

Would it make sense to remove the language altogether like done here https://github.com/microsoft/TypeScript/blob/main/.github/workflows/codeql.yml?

aeisenberg commented 2 years ago

Typescript and javascript are synonyms for this purpose. The workflow you have is duplicating work. You only need to specify one of the languages.

oliviertassinari commented 2 years ago

@aeisenberg Awesome thanks for the confirmation. I will update http://github.com/mui/material-ui configurations too.