github / codeql-action

Actions for running CodeQL analysis
MIT License
1.14k stars 316 forks source link

Alerts are repeatedly opened and closed by unrelated commits. #1445

Open eli-schwartz opened 1 year ago

eli-schwartz commented 1 year ago

Here is an example alert. https://github.com/mesonbuild/meson/pull/11218/checks?check_run_id=10309314938

Fixed alerts

Unused local variable (unittests/baseplatformtests.py:219)

This points to the following code: https://github.com/mesonbuild/meson/blob/891b4ffe3372c840322f5586430dcba34acf6d53/unittests/baseplatformtests.py#L219-L219

... but the commit in question doesn't modify that code, and it certainly doesn't fix that.

Now, if I go look at the history of this alert....


First detected in commit Nov 25, 2022 @ eli-schwartz Merge https://github.com/mesonbuild/meson/commit/f52936a8c5be498446e6f0ee98296b28ea8c7968 into https://github.com/mesonbuild/meson/commit/11fe8f11579d46870ed340dca8234ea35edf769c 86a6b42 unittests/baseplatformtests.py:219 on branch refs/pull/11108/merge Appeared in branch refs/pull/11108/merge Nov 25, 2022 CodeQL #8: Commit 86a6b42b Fixed in branch refs/pull/11108/merge Nov 25, 2022 @ eli-schwartz Merge https://github.com/mesonbuild/meson/commit/f52936a8c5be498446e6f0ee98296b28ea8c7968 into https://github.com/mesonbuild/meson/commit/11fe8f11579d46870ed340dca8234ea35edf769c 86a6b42 Reappeared in branch refs/pull/11108/merge Nov 25, 2022 @ eli-schwartz Merge https://github.com/mesonbuild/meson/commit/b1f41107d76701efecc8cdde3ba798e992a2f0a0 into https://github.com/mesonbuild/meson/commit/11fe8f11579d46870ed340dca8234ea35edf769c 977e61e unittests/baseplatformtests.py:219 on branch refs/pull/11108/merge Appeared in branch master Nov 25, 2022 Commit f64e5cee Fixed in branch master Nov 25, 2022 @ jpakkane Prepare release 0.61.0. 9e1f207 Reappeared in branch master Nov 25, 2022 @ jpakkane Prepare the 0.62.0 release. fb67adf unittests/baseplatformtests.py:208 on branch master Fixed in branch master Nov 25, 2022 @ jpakkane Finalize the release. 9c6dab2 Reappeared in branch master Nov 28, 2022 @ eli-schwartz @ dcbaker Add github's CodeQL scanner to CI. 5022fd3 unittests/baseplatformtests.py:219 on branch master Fixed in branch master Nov 28, 2022 @ jpakkane Don't ignore documentation-related flags for D compilers 23fcea1 Reappeared in branch master Nov 28, 2022 @ smallwood-d @ duckflyer @ jpakkane Fix crash when toolchain is missing d32ee58 unittests/baseplatformtests.py:219 on branch master Appeared in branch refs/pull/11115/merge Nov 28, 2022 CodeQL #19: Commit 38594dcd Fixed in branch refs/pull/11115/merge Nov 29, 2022 @ obilaniu Merge https://github.com/mesonbuild/meson/commit/68da84fba3fd3ac0742352605d54b985c70c23c7 into https://github.com/mesonbuild/meson/commit/1a6a014494785e107023b25c157b30c3a4838b99 87ec9c6 Fixed in branch master Nov 29, 2022 @ obilaniu @ eli-schwartz CUDA: Update minimum driver version table to include CUDA 11.8 6190b64 Appeared in branch refs/pull/9865/merge Nov 29, 2022 CodeQL #29: Commit f12cd573 Fixed in branch refs/pull/11117/merge Nov 30, 2022 @ eli-schwartz Merge https://github.com/mesonbuild/meson/commit/67da2ad0fb3a0e45bd878d21aa1c5d956214c483 into https://github.com/mesonbuild/meson/commit/e8727fc8571bc8b9dc23255c267b52478d12e66f ae66d91 Fixed in branch refs/pull/11119/merge Nov 30, 2022 @ fooishbar Merge https://github.com/mesonbuild/meson/commit/3393c818812317a0338755aa965ad2b03837e25d into https://github.com/mesonbuild/meson/commit/e8727fc8571bc8b9dc23255c267b52478d12e66f 3fb025b Reappeared in branch refs/pull/11119/merge Nov 30, 2022 @ fooishbar Merge https://github.com/mesonbuild/meson/commit/1b98549c706aa11d4281105616c020903725a965 into https://github.com/mesonbuild/meson/commit/e8727fc8571bc8b9dc23255c267b52478d12e66f 237b096 unittests/baseplatformtests.py:219 on branch refs/pull/11119/merge Reappeared in branch master Nov 30, 2022 @ dcbaker @ eli-schwartz pylint: enable simplifiable-if-statement 67da2ad unittests/baseplatformtests.py:219 on branch master Fixed in branch refs/pull/11119/merge Nov 30, 2022 @ fooishbar Merge https://github.com/mesonbuild/meson/commit/aaebb1f45f7b12d31578b44624481f3cc395a4d7 into https://github.com/mesonbuild/meson/commit/67da2ad0fb3a0e45bd878d21aa1c5d956214c483 7f38298 Fixed in branch master Nov 30, 2022 @ fooishbar @ dcbaker tests: Write out LD_LIBRARY_PATH for built shared libraries a0514a7 Reappeared in branch master Nov 30, 2022 @ eli-schwartz docs: clarify that prog.full_path has potentially valid uses dcc50b9 unittests/baseplatformtests.py:219 on branch master Fixed in branch master Nov 30, 2022 @ eli-schwartz docs: clarify prog.full_path even more fae24d8 Reappeared in branch master Nov 30, 2022 @ sashashura @ eli-schwartz build: harden workflow permissions 9074ad9 unittests/baseplatformtests.py:219 on branch master Fixed in branch refs/pull/11126/merge Dec 1, 2022 @ amyspark Merge https://github.com/mesonbuild/meson/commit/617c3f6e64728712390071deb6d9be3c6a3af46c into https://github.com/mesonbuild/meson/commit/9074ad93c6675cdb603b85d85a8090100058f81b a96c6ef Reappeared in branch refs/pull/11126/merge Dec 1, 2022 @ amyspark Merge https://github.com/mesonbuild/meson/commit/62dceecffc87812d3d76b7994bf852d92ea91a68 into https://github.com/mesonbuild/meson/commit/9074ad93c6675cdb603b85d85a8090100058f81b 3d33ea9 unittests/baseplatformtests.py:219 on branch refs/pull/11126/merge Fixed in branch refs/pull/11127/merge Dec 1, 2022 @ amyspark Merge https://github.com/mesonbuild/meson/commit/d804624a9c6ffe468174162d2395af3f04cc9cad into https://github.com/mesonbuild/meson/commit/9074ad93c6675cdb603b85d85a8090100058f81b 89a806e Fixed in branch master Dec 5, 2022 @ mchampanis @ eli-schwartz dependencies: only print not_found_message once f194413 Reappeared in branch master Dec 5, 2022 @ fanf2 @ eli-schwartz docs: change old SourceForge link to GitHub 8a72558 unittests/baseplatformtests.py:219 on branch master Fixed in branch master Dec 5, 2022 @ wally-mageia @ eli-schwartz Use meson setup [options] in meson RPM macro 99dfc98 Reappeared in branch master Dec 5, 2022 @ dcbaker @ eli-schwartz modules/rust: Add support for string include_directories bb87528 unittests/baseplatformtests.py:219 on branch master Fixed in branch refs/pull/10714/merge Dec 5, 2022 @ dcbaker Merge https://github.com/mesonbuild/meson/commit/12c91afd4f85980d41250192e05e6c1810820c36 into https://github.com/mesonbuild/meson/commit/bb875280b695b8d0435833c192f99233e74a522a 633906f Reappeared in branch refs/pull/11127/merge Dec 6, 2022 @ amyspark Merge https://github.com/mesonbuild/meson/commit/bb2a68a4c1285c8de19c70118d4fa745ec9e78af into https://github.com/mesonbuild/meson/commit/d0054f2c3c3497e22069d1efb5b1d985d75fe5ca 93ecaac unittests/baseplatformtests.py:219 on branch refs/pull/11127/merge Fixed in branch refs/pull/11127/merge Dec 6, 2022 @ amyspark Merge https://github.com/mesonbuild/meson/commit/ef11b6c676d5789e168f09dc154ada510ef1a1d3 into https://github.com/mesonbuild/meson/commit/d0054f2c3c3497e22069d1efb5b1d985d75fe5ca df25978 Fixed in branch master Dec 6, 2022 @ szanni @ xclaesse docs: Add missing import to the windows module example. cee7ecd Fixed in branch refs/pull/11125/merge Dec 6, 2022 @ amyspark Merge https://github.com/mesonbuild/meson/commit/9e36923c72eec7100dd7d7c7314cabadf18dd7b6 into https://github.com/mesonbuild/meson/commit/bcd50e71d51eac2fa8e1afbb30cb7d5260e0f42a 4a7a122 Reappeared in branch refs/pull/11125/merge Dec 6, 2022 @ amyspark Merge https://github.com/mesonbuild/meson/commit/4d361287a06cfe3c7ba6eb09751d36c640f8ab9a into https://github.com/mesonbuild/meson/commit/bcd50e71d51eac2fa8e1afbb30cb7d5260e0f42a 4b95d05 unittests/baseplatformtests.py:219 on branch refs/pull/11125/merge Reappeared in branch refs/pull/10714/merge Dec 6, 2022 @ dcbaker Merge https://github.com/mesonbuild/meson/commit/7c0053594359f347eab9b0384c354ce60fbd0b72 into https://github.com/mesonbuild/meson/commit/bcd50e71d51eac2fa8e1afbb30cb7d5260e0f42a ac70545 unittests/baseplatformtests.py:219 on branch refs/pull/10714/merge Fixed in branch refs/pull/10714/merge Dec 6, 2022 @ dcbaker Merge https://github.com/mesonbuild/meson/commit/d0a5eaa1ee94d4a678fd11166b7b577e5e2aa0e6 into https://github.com/mesonbuild/meson/commit/bcd50e71d51eac2fa8e1afbb30cb7d5260e0f42a 94fde44 Appeared in branch refs/pull/10990/merge Dec 7, 2022 CodeQL #107: Commit b4efe3e5 Reappeared in branch refs/pull/10714/merge Dec 7, 2022 @ dcbaker Merge https://github.com/mesonbuild/meson/commit/3a56afdcacaf4fe5f0cca26b9e98230e602edb10 into https://github.com/mesonbuild/meson/commit/d490636328e78984af0b80c70a8217c4f9cf9c52 6968b65 unittests/baseplatformtests.py:219 on branch refs/pull/10714/merge Reappeared in branch refs/pull/11127/merge Dec 7, 2022 @ amyspark Merge https://github.com/mesonbuild/meson/commit/068d5e1905fedf4752644fe64d9ed80a2a70e59d into https://github.com/mesonbuild/meson/commit/d490636328e78984af0b80c70a8217c4f9cf9c52 df48ed4 unittests/baseplatformtests.py:219 on branch refs/pull/11127/merge Fixed in branch refs/pull/11127/merge Dec 7, 2022 @ amyspark Merge https://github.com/mesonbuild/meson/commit/dd7c9e234f66cdb87719a947febe415756433f29 into https://github.com/mesonbuild/meson/commit/d490636328e78984af0b80c70a8217c4f9cf9c52 5230edf Reappeared in branch refs/pull/11127/merge Dec 7, 2022 @ amyspark Merge https://github.com/mesonbuild/meson/commit/24197c5869f8e40e25c2bea0d9b4d67612a1d21a into https://github.com/mesonbuild/meson/commit/d490636328e78984af0b80c70a8217c4f9cf9c52 f81e38a unittests/baseplatformtests.py:220 on branch refs/pull/11127/merge Fixed in branch refs/pull/11127/merge Dec 7, 2022 @ amyspark Merge https://github.com/mesonbuild/meson/commit/ce277753f92c8302db3f4b646bf5243a66764ab2 into https://github.com/mesonbuild/meson/commit/d490636328e78984af0b80c70a8217c4f9cf9c52 22eb334 Fixed in branch refs/pull/11147/merge Dec 8, 2022 @ dcbaker Merge https://github.com/mesonbuild/meson/commit/f427aefb330c4d64f79a7c08bedbf11c80f60ec2 into https://github.com/mesonbuild/meson/commit/d490636328e78984af0b80c70a8217c4f9cf9c52 2a937f8 Reappeared in branch refs/pull/11127/merge Dec 9, 2022 @ amyspark Merge https://github.com/mesonbuild/meson/commit/14857472398efe3ec477225a7ea5f956885e0866 into https://github.com/mesonbuild/meson/commit/d490636328e78984af0b80c70a8217c4f9cf9c52 b8d265b unittests/baseplatformtests.py:220 on branch refs/pull/11127/merge Reappeared in branch master Dec 9, 2022 @ eli-schwartz @ jpakkane python module: don't overwrite and destroy the .pc dependency name 7b2c47e unittests/baseplatformtests.py:219 on branch master Fixed in branch refs/pull/11150/merge Dec 9, 2022 @ dcbaker Merge https://github.com/mesonbuild/meson/commit/d63c0ba6e612012b97a83ef3e2cf17030297680b into https://github.com/mesonbuild/meson/commit/2ec3fe7a4af5bd4d8a83947d675f9233805f3dfd 05f2eca Fixed in branch master Dec 9, 2022 @ xclaesse @ jpakkane doc: Add date in release notes 17c0a7f Appeared in branch refs/pull/11071/merge Dec 9, 2022 CodeQL #139: Commit 20f15461 Fixed in branch refs/pull/11127/merge Dec 10, 2022 @ amyspark Merge https://github.com/mesonbuild/meson/commit/5de6a09428d4620b26d759cabc3e088264107fe1 into https://github.com/mesonbuild/meson/commit/17c0a7f76a3168cd568c33fbad2824da2d702764 bd07c59 Fixed in branch refs/pull/11071/merge Dec 10, 2022 @ tristan957 Merge https://github.com/mesonbuild/meson/commit/679721e75659cef68b6582c54b63d54df64a75ff into https://github.com/mesonbuild/meson/commit/17c0a7f76a3168cd568c33fbad2824da2d702764 b3e39cb Reappeared in branch master Dec 10, 2022 @ jpakkane Merge pull request https://github.com/mesonbuild/meson/pull/11024 from dcbaker/submit/bindgen-dependencies dbb33aa unittests/baseplatformtests.py:219 on branch master Fixed in branch master Dec 10, 2022 @ obilaniu @ jpakkane CUDA: Update compute-capability limits logic for CUDA 12. 255f335 Fixed in branch refs/pull/11144/merge Dec 11, 2022 @ philj56 Merge https://github.com/mesonbuild/meson/commit/53fa268368bd19f094928c78a835990117735c77 into https://github.com/mesonbuild/meson/commit/255f335d8e305d4cad261484d5d3e0f80b82d886 8b5814e Reappeared in branch refs/pull/11071/merge Dec 11, 2022 @ tristan957 Merge https://github.com/mesonbuild/meson/commit/dfea023ced8b48b318826738f54328ea24ef63b3 into https://github.com/mesonbuild/meson/commit/5bea2ca198041fa044222dc5b8b63b155e525d5c 6cac840 unittests/baseplatformtests.py:219 on branch refs/pull/11071/merge Appeared in branch refs/pull/11159/merge Dec 11, 2022 CodeQL #158: Commit 30b9ec0b Reappeared in branch refs/pull/11147/merge Dec 12, 2022 @ dcbaker Merge https://github.com/mesonbuild/meson/commit/69dafc0204b327a9ef9d4a2a94d27912528bab9e into https://github.com/mesonbuild/meson/commit/b249470a4c1de39a0a56d9237f767fe04d6efa05 79018af unittests/baseplatformtests.py:219 on branch refs/pull/11147/merge Fixed in branch refs/pull/11151/merge Dec 13, 2022 @ brad0 Merge https://github.com/mesonbuild/meson/commit/7d452aa46c6bcd47966df75b98a5a7f7d849fcb2 into https://github.com/mesonbuild/meson/commit/b249470a4c1de39a0a56d9237f767fe04d6efa05 6696531 Appeared in branch refs/pull/11135/merge Dec 14, 2022 CodeQL #174: Commit 5c4fa472 Appeared in branch refs/pull/11174/merge Dec 14, 2022 CodeQL #176: Commit 8ad6105e Fixed in branch refs/pull/11135/merge Dec 14, 2022 @ bonktree Merge https://github.com/mesonbuild/meson/commit/96f0ecac69459ae44a8b6b030ab7ac275c1700b7 into https://github.com/mesonbuild/meson/commit/dd25b88f009ee47579b33dfbd167a9434cc8f2be 6b93707 Fixed in branch refs/pull/11179/merge Dec 14, 2022 @ dcbaker Merge https://github.com/mesonbuild/meson/commit/66b6671852eca089832d4b4c3637a0fe7ce1536a into https://github.com/mesonbuild/meson/commit/dd25b88f009ee47579b33dfbd167a9434cc8f2be 55511a0 Reappeared in branch refs/pull/11179/merge Dec 14, 2022 @ dcbaker Merge https://github.com/mesonbuild/meson/commit/a4a38da4b427bb581379238875a5780a76ebb0b1 into https://github.com/mesonbuild/meson/commit/dd25b88f009ee47579b33dfbd167a9434cc8f2be c0dbedb unittests/baseplatformtests.py:219 on branch refs/pull/11179/merge Fixed in branch refs/pull/11174/merge Dec 14, 2022 @ bgilbert Merge https://github.com/mesonbuild/meson/commit/35e230e48ca42f4ccb872d1d01f9280f8015b417 into https://github.com/mesonbuild/meson/commit/dd25b88f009ee47579b33dfbd167a9434cc8f2be 8740802 Appeared in branch refs/pull/10582/merge Dec 14, 2022 CodeQL #185: Commit b60712a2 Fixed in branch refs/pull/10582/merge Dec 14, 2022 @ dcbaker Merge https://github.com/mesonbuild/meson/commit/0ff70e7b5f11796704258767da2c6ad876e56b98 into https://github.com/mesonbuild/meson/commit/dd25b88f009ee47579b33dfbd167a9434cc8f2be b894bd8 Reappeared in branch master Dec 14, 2022 @ eli-schwartz docs: clarify the semantics of the required: kwarg everywhere 57f91bb unittests/baseplatformtests.py:219 on branch master Fixed in branch refs/pull/11175/merge Dec 14, 2022 @ Akaricchi Merge https://github.com/mesonbuild/meson/commit/4814a392963065abf02e9daf2af3a8aa3ba3fdc2 into https://github.com/mesonbuild/meson/commit/57f91bb593b9eebf772a16a5519de58996d27c3a 93a22c4 Reappeared in branch refs/pull/10582/merge Dec 15, 2022 @ dcbaker Merge https://github.com/mesonbuild/meson/commit/445fa1b6a2c347eca1aeb1756f88673aa6bc6224 into https://github.com/mesonbuild/meson/commit/57f91bb593b9eebf772a16a5519de58996d27c3a 2a1aed0 unittests/baseplatformtests.py:219 on branch refs/pull/10582/merge Fixed in branch refs/pull/10582/merge Dec 15, 2022 @ dcbaker Merge https://github.com/mesonbuild/meson/commit/2922f8949b042b1ebf579e12c2bb3ce0cdee8445 into https://github.com/mesonbuild/meson/commit/57f91bb593b9eebf772a16a5519de58996d27c3a f1c9a65 Fixed in branch refs/pull/11179/merge Dec 15, 2022 @ dcbaker Merge https://github.com/mesonbuild/meson/commit/58340a76a70aee98b9b73348ec6e8fb9ccd9f130 into https://github.com/mesonbuild/meson/commit/57f91bb593b9eebf772a16a5519de58996d27c3a 3f1bde8 Appeared in branch refs/pull/11181/merge Dec 15, 2022 CodeQL #195: Commit a6aacab9 Fixed in branch refs/pull/11181/merge Dec 15, 2022 @ tristan957 Merge https://github.com/mesonbuild/meson/commit/6ed5c8cd6d4aafbd4dda416f43294f13781d98ca into https://github.com/mesonbuild/meson/commit/57f91bb593b9eebf772a16a5519de58996d27c3a 2ae5f2d Fixed in branch master Dec 15, 2022 @ eli-schwartz delay importing ctypes unless it is actually used 2ef94a7 Reappeared in branch refs/pull/11181/merge Dec 15, 2022 @ tristan957 Merge https://github.com/mesonbuild/meson/commit/fb6fda385391ac5d030b4e642fc426ada5d80488 into https://github.com/mesonbuild/meson/commit/2ef94a71f8072567e39f22bfed7bcae0ca2038c2 9d120a5 unittests/baseplatformtests.py:219 on branch refs/pull/11181/merge Fixed in branch refs/pull/11181/merge Dec 15, 2022 @ tristan957 Merge https://github.com/mesonbuild/meson/commit/71cddebf2c6093fe52de01329847926801f87f35 into https://github.com/mesonbuild/meson/commit/2ef94a71f8072567e39f22bfed7bcae0ca2038c2 0d604df Reappeared in branch master Dec 16, 2022 @ jpakkane Merge pull request https://github.com/mesonbuild/meson/pull/11174 from bgilbert/jar-manifest 27bd499 unittests/baseplatformtests.py:219 on branch master Fixed in branch refs/pull/10714/merge Dec 16, 2022 @ dcbaker Merge https://github.com/mesonbuild/meson/commit/1b2216c500a9f18436d427ed74888e7740b62b55 into https://github.com/mesonbuild/meson/commit/27bd499772483c620bc0eca219edf2707de3dee6 25aeed2 Reappeared in branch refs/pull/10714/merge Dec 16, 2022 @ dcbaker Merge https://github.com/mesonbuild/meson/commit/1725e62fb4faa2a75b48aa4979efaa41baf5d8e8 into https://github.com/mesonbuild/meson/commit/27bd499772483c620bc0eca219edf2707de3dee6 68d9795 unittests/baseplatformtests.py:219 on branch refs/pull/10714/merge Appeared in branch refs/pull/11188/merge Dec 18, 2022 CodeQL #217: Commit 536499f1 Fixed in branch refs/pull/11188/merge Dec 18, 2022 @ nirbheek Merge https://github.com/mesonbuild/meson/commit/9fc425c4e3acb5766f9d2d138d0c725aff5dfa5e into https://github.com/mesonbuild/meson/commit/9c1b6a95b06db3d2a167251488a496465221300e cfd48d6 Fixed in branch refs/pull/11197/merge Dec 19, 2022 @ bonzini Merge https://github.com/mesonbuild/meson/commit/34286929336b167fb0c6ab02497a345be7277347 into https://github.com/mesonbuild/meson/commit/9c1b6a95b06db3d2a167251488a496465221300e 14d36c1 Appeared in branch refs/pull/11198/merge Dec 19, 2022 CodeQL #226: Commit 3bb01a78 Fixed in branch refs/pull/11198/merge Dec 19, 2022 @ bonzini Merge https://github.com/mesonbuild/meson/commit/d43d9c4a83cbd0cd313999492da9f0421f4dc4e9 into https://github.com/mesonbuild/meson/commit/9c1b6a95b06db3d2a167251488a496465221300e 8d3dfb0 Fixed in branch master Dec 19, 2022 @ amitdo @ eli-schwartz Users.md: Add PostgreSQL 2e54f77 Appeared in branch refs/pull/11201/merge Dec 21, 2022 CodeQL #235: Commit 99cbc837 Fixed in branch refs/pull/11203/merge Dec 21, 2022 @ xclaesse Merge https://github.com/mesonbuild/meson/commit/8f935e9673bcf6f58dd9c644c672da843d44298e into https://github.com/mesonbuild/meson/commit/2e54f772d396daf79c817aea6848fbb324aa0f59 d746d6d Reappeared in branch master Dec 21, 2022 @ xclaesse @ eli-schwartz doc: Add missing include_directories kwarg to compiler.preprocess() a0b37a7 unittests/baseplatformtests.py:219 on branch master Fixed in branch refs/pull/11207/merge Dec 21, 2022 @ dcbaker Merge https://github.com/mesonbuild/meson/commit/5ceed3f99e21a8498163ec1c740c83442397ecb9 into https://github.com/mesonbuild/meson/commit/99713ae257cae6f86b3b34ddf474a8cff247ea29 8108f68 Fixed in branch master Dec 21, 2022 @ bonzini @ dcbaker add more testcases for prebuilt objects b38bf09 Reappeared in branch master Dec 23, 2022 @ jpakkane Bump version number for new development. 8e2355e unittests/baseplatformtests.py:219 on branch master Fixed in branch master Dec 24, 2022 @ dcbaker interpreter: use static_lib's already calculated pic value 2fd5bd9 Fixed in branch refs/pull/11213/merge Dec 25, 2022 @ bluca Merge https://github.com/mesonbuild/meson/commit/b3ee443c2fc710cd51bc8cd697b1881eec9e8f9e into https://github.com/mesonbuild/meson/commit/2fd5bd934e0e6dd26ad8c326a156a710f912b335 0cd3b90 Reappeared in branch refs/pull/11213/merge Dec 25, 2022 @ bluca Merge https://github.com/mesonbuild/meson/commit/3385accc59fa67be4e8aa4fb2c3cc69cea5b05f3 into https://github.com/mesonbuild/meson/commit/2fd5bd934e0e6dd26ad8c326a156a710f912b335 16465e7 unittests/baseplatformtests.py:219 on branch refs/pull/11213/merge Fixed in branch refs/pull/11213/merge Dec 26, 2022 @ bluca Merge https://github.com/mesonbuild/meson/commit/f0f17012120d3fda0bfb71ef72986668a182c1c0 into https://github.com/mesonbuild/meson/commit/2fd5bd934e0e6dd26ad8c326a156a710f912b335 6563bdc Reappeared in branch master Dec 26, 2022 @ eli-schwartz dependencies: better logging of pkg-config call outputs 891b4ff unittests/baseplatformtests.py:219 on branch master Appeared in branch refs/pull/11164/merge Dec 26, 2022 CodeQL #267: Commit 42758023

adityasharad commented 1 year ago

Thanks for the detailed report, and for your patience -- we have limited support coverage during this holiday period, and I'm just catching up with this particular issue.

I had a brief look at the data from recent code scanning runs on your repo. I suspect the problem you observed occurred during the rollout of CodeQL 2.11.4 in the tool cache in the default Actions runner image. Some runs on this repo obtained CodeQL 2.11.3, and some runs obtained CodeQL 2.11.4, which in turn can lead to the spurious opening and closing of alerts due to differences in analysis between those versions.

We are aware of this problem in general, and it is a high-priority item for us to fix at the start of the new year, ensuring that your alerts are stable even when a new CodeQL version is being rolled out. Until then please accept my apologies for the inconvenience -- we know how disruptive it can be to have your alerts close and reopen in this way.

As a temporary workaround, you can set tools: latest in the with: section of the codeql-action/init@v2 step in your workflow, which will bypass the cache and always download the latest version of CodeQL. This will give you more consistency in the CodeQL version being used across workflow runs, at the cost of an extra ~1min in each run. (If it is inconvenient to modify the workflow, we can temporarily enable the same behaviour for you on the GitHub server side. Let us know if you prefer that.)

Please let us know in case you are still observing the problem with the above workaround. I'll leave this issue open until we have completed and rolled out the fix I mentioned so that you can avoid the workaround.

eli-schwartz commented 1 year ago

Thanks for the advice. I've just deployed this change in https://github.com/mesonbuild/meson/commit/334d2137e9b224a655007b0b7c328e1c95320027 and I'll report back.

eli-schwartz commented 1 year ago

I still see this issue, see for example https://github.com/mesonbuild/meson/runs/10493109542

The matching analyze job: https://github.com/mesonbuild/meson/actions/runs/3859141415/jobs/6578397228#step:3:12

Fixed in branch master Jan 4, 2023 @ andy5995 @ eli-schwartz Users.md: add slapt-get 25e73b6 Reappeared in branch master Jan 8, 2023 @ eli-schwartz @ xclaesse avoid detecting masm as a MSVC-like compiler for detecting showincludes b9b27d3 unittests/baseplatformtests.py:219 on branch master Fixed in branch refs/pull/11243/merge Jan 9, 2023 @ jackwil1 Merge https://github.com/mesonbuild/meson/commit/e787f9e180f8fffd86e5e716e1fd6a50eaab8c55 into https://github.com/mesonbuild/meson/commit/cb20486f37c0dfce60e541e512d2ceaa6e0b701e 7ec4236 Appeared in branch refs/pull/11268/merge Jan 9, 2023 CodeQL #348: Commit 31cf1102 Fixed in branch refs/pull/11268/merge Jan 9, 2023 @ dcbaker Merge https://github.com/mesonbuild/meson/commit/e966d48653c6c145c0238577e9e3dbce6d92b76d into https://github.com/mesonbuild/meson/commit/ded57707c8196eda2fcf7ea507e7e2b38f9a7d19 b5ff4f8 Reappeared in branch refs/pull/11268/merge Jan 9, 2023 @ dcbaker Merge https://github.com/mesonbuild/meson/commit/e04c3a0232219b2f2efa67f515ebd4fbcb1c2fa3 into https://github.com/mesonbuild/meson/commit/ded57707c8196eda2fcf7ea507e7e2b38f9a7d19 d73cdfb unittests/baseplatformtests.py:219 on branch refs/pull/11268/merge Fixed in branch master Jan 10, 2023 @ dcbaker modules: fully type the Qt* modules 6ed6c8c Reappeared in branch master Jan 10, 2023 @ dcbaker @ eli-schwartz docs: Add ld64.lld to linker reference table 8655287 unittests/baseplatformtests.py:219 on branch master Appeared in branch refs/pull/11273/merge Jan 10, 2023 CodeQL #360: Commit cad75877