github / codeql-action

Actions for running CodeQL analysis
MIT License
1.12k stars 310 forks source link

Merge releases/v3 into releases/v2 #2289

Closed henrymercer closed 3 months ago

henrymercer commented 3 months ago

Merging b7cec7526 into releases/v2.

Conductor for this PR is @henrymercer.

Contains the following pull requests:

Please do the following:

github-actions[bot] commented 3 months ago

Pushed a commit to update the checked-in dependencies. Please mark the PR as ready for review to trigger PR checks.

NlightNFotis commented 3 months ago

Hello, don't know how useful my review on this would be, but happy to do a review if needed.

I do have a question though, just to build my understanding of our process:

This is the PR that adds the new features to the release branch correct? Assuming it gets merged, this means that anyone using the action/v2 will be able to pick these changes up next time they run the action. Or am I misunderstanding?

NlightNFotis commented 3 months ago

On second thoughts, I had a look at the diff, and this appears to be just a sync PR, needing just a stamp. Happy to give it to unblock us.

henrymercer commented 3 months ago

That's right — currently we bring all the latest features from v3 into v2 (apart from Node 20 support), and to do that we have a backport PR like this each time we release the CodeQL Action. Usually it's automatically generated, but this one updated a workflow file, and updating workflow files requires a PAT, so we had to run it manually. Thanks for the review!