Refactoring: Simplify upload SARIF flow and reuse loaded flags

github / codeql-action

Actions for running CodeQL analysis

MIT License

1.09k stars 305 forks source link

Refactoring: Simplify upload SARIF flow and reuse loaded flags #2361

Closed henrymercer closed 1 week ago

henrymercer commented 2 weeks ago

Minor refactoring to simplify the flow for uploading SARIF files, and to reuse the loaded feature flags if we've already loaded them from disk or from the API.

Merge / deployment checklist

[ ] Confirm this change is backwards compatible with existing workflows.
[ ] Confirm the readme has been updated if necessary.
[ ] Confirm the changelog has been updated if necessary.

angelapwen commented 1 week ago

💭 The submit SARIF after failure workflow on main seems to be failing now after this was merged 😢 (though I'm not sure why it didn't fail in this PR's checks).

aeisenberg commented 1 week ago

The latest run on main is passing, but I see the run associated with https://github.com/github/codeql-action/pull/2364 is failing. I'm rerunning since it might be transient.

aeisenberg commented 1 week ago

...and it passed! So, guessing the error came from the server side.

henrymercer commented 1 week ago

This was due to an internal experiment on the API endpoints (unrelated to this PR). The relevant feature flag is now disabled. I've cced you in Slack.