search

github / codeql-action

Actions for running CodeQL analysis
MIT License
1.16k stars 322 forks source link

Scanning Swift code doesn't work when building with Xcode 16 #2506

Open bwhtmn opened 1 month ago

bwhtmn commented 1 month ago

Running a CodeQL scan on Swift code using a manual build fails, when building with Xcode 16.0 with the following error message:

CodeQL detected code written in Swift but this run didn't build any of it, or CodeQL could not process any of it. Ensure that you have provided manual build steps (see https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/codeql-code-scanning-for-compiled-languages#about-specifying-build-steps-manually) for Swift between the 'init' and 'analyze' Actions, and check the workflow run logs (see https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/using-workflow-run-logs). For more information, review our troubleshooting guide at https://gh.io/troubleshooting-code-scanning/no-source-code-seen-during-build .

Building with Xcode 15.4 doesn't have this issue. I've reproduced this with a basic sample app (just using the new app template from Xcode) to verify that it's not specific to our app configuration.

smowton commented 1 month ago

Are you able to share a link to your example repository so we can review logs etc?

bwhtmn commented 1 month ago

Sure! Here's a link to my sample repo: https://github.com/bwhtmn/codeql-xcode16 You can see 3 action runs. The first one is using Xcode 15.4 and succeeds. The next two are using Xcode 16.0 and fail, with the error noted above.

smowton commented 1 month ago

Thanks -- we suspect this relates to Swift 6 support; we'll investigate and confirm.

ajaysubra commented 1 month ago

@smowton I may be facing the same issue with this repo - https://github.com/klaviyo/klaviyo-swift-sdk/

bernhardkreminski-qm commented 2 weeks ago

@smowton do you have an update? We face the same issues by just updating the Xcode version, upgrading swift in the project was not involved.

andersfugmann commented 2 weeks ago

We are currently investigating problems related to scanning Swift code when using Xcode 16 and Swift 6.0. We cannot share any timelines on how long this will take just yet, or when support will be available. After we complete our initial investigation, we'll try to share an estimate on when support to Xcode 16 and Swift 6.0 will be available.

bernhardkreminski-qm commented 2 weeks ago

Thanks for the update. What about Xcode 16 not using swift 6? From my point of view this are two disjunct topics. Do you want to tackle them individually or together? Thanks!

drekka commented 3 days ago

Not sure if I'm getting the same results as this is the first time I've attempted to use CodeQL and I'm follow some work done by another developer.

To setup I did the following things. First I created a make.sh script in the root of the project containing:

#!/bin/sh
xcodebuild build -workspace MyProject.xcworkspace -scheme MyProject  -configuration Debug CODE_SIGN_IDENTITY="" APP_SHORTCUTS_ENABLE_FLEXIBLE_MATCHING=NO

Then I installed CodeQL CLI bundle from https://github.com/github/codeql-action/releases and ran

codeql/codeql database create ./dbs/mobile --language=swift --source-root . --overwrite --command="./make.sh"

Followed by:

codeql/codeql database analyze ./dbs/mobile --format csv --output results.csv

Which barfed with a bunch of errors about the swift code pack being missing. Which was strange as I thought it had come down with the CLI and when I looked in the codeql/ folder there was a swift folder present along with a bunch of other languages.

So I dug around the internet and eventually ran:

codeql/codeql pack download codeql/swift-queries

which seemed to install some stuff, then ran the analyze again. This time it seemed to work, however told me there was 288 unresolved AST nodes and produced an empty results.csv file.

So now I'm a bit stuck as to what to do next. Or if this is even working.

simonmcl commented 2 days ago

Just switched my project to Xcode 16/macos-15 and seeing failures in CodeQL too

I have a job that builds and runs unit tests, this completes fine. I have a second job that inits codeQL, builds the project, and its failing. I'm seeing issues in the console like:

Library not loaded: @rpath/libSwiftSyntax.dylib
...
Reason: tried: '/Users/runner/work/_temp/codeql_databases/working/copy-root/000001F5/Applications/Xcode_16.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/Frameworks/libSwiftSyntax.dylib' (no such file),

Heres a link to the action result if you would like to examine: https://github.com/kukai-wallet/kukai-core-swift/actions/runs/11497720372/job/32002002011