Closed MichaelRFairhurst closed 2 months ago
This PR is blocked, codeql run test
automatically adds a -w
flag during extraction, therefore we cannot create a \\ COMPLIANT
test case via codeql run test
.
@lcartey Should we remove the "compliant" test cases for now, so we can fix this false negative? Or should we wait for a plan, either via changes to our test infra or to codeql run test
, so that we can land this with both compliant & non-compliant test cases?
Description
Gcc may be compiled to auto include warnings such as -Wformat. However, passing in
-w
will suppress the enabled format warnings. The previous query would not raise an issue, as it saw the-Wformat
flag etc, even though if-w
was present, causing gcc to run with no warnings enabled.Change request type
.ql
,.qll
,.qls
or unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨 Reviewer: Confirm that format of shared queries (not the .qll file, the .ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.