github / codeql-coding-standards

This repository contains CodeQL queries and libraries which support various Coding Standards.
MIT License
129 stars 60 forks source link

Fix #689, false negatives for A1-1-2 thinking -Wno-foo is compliant. #697

Closed MichaelRFairhurst closed 1 month ago

MichaelRFairhurst commented 2 months ago

Description

The presence of -Wno-foo should not mark the compilation compliant with A1-1-2, nor should the presence of -Wfoo=0.

Easily check for all -Wfoo=bar flags, that foo is not no-baz, and bar is not 0. Also check there is no -Wno-foo flag overruling it. Otherwise the query functionality remains the same.

Add test cases for non-compliant scenarios -Wfoo=0 and -Wno-foo, and for the compliant scenario -Wall -Wno-foo.

This will have some compatibility issues with PR #688, after one is merged the other will need some small updates before this can be merged.

Change request type

Rules with added or modified queries

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

🚨🚨🚨 Reviewer: Confirm that format of shared queries (not the .qll file, the .ql file that imports it) is valid by running them within VS Code.

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

Reviewer

lcartey commented 1 month ago

@MichaelRFairhurst I believe this now needs updating, after we merged https://github.com/github/codeql-coding-standards/pull/688.