PR #690 was merged last week despite having CodeQL compilation issues. This PR ensures the Validate test results job reports failure in the case that a dependent matrix job fails to execute (e.g. due to a CodeQL compilation error). Previously it reported "skipped", which was sufficient for the status check on the PR to pass and to allow it to be merged.
This is achieved by ensuring the Validate test results job is always run, and then checking if the run-test-suites job failed to complete, and aborting early if it did.
The evaluation performance (memory, execution time) of an existing query.
The results of an existing query in any circumstance.
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
[ ] Yes
[x] No
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
[ ] Confirmed
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
[ ] Confirmed
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
[ ] Have all the relevant rule package description files been checked in?
[ ] Have you verified that the metadata properties of each new query is set appropriately?
[ ] Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
[ ] Are the alert messages properly formatted and consistent with the style guide?
[ ] Have you run the queries on OpenPilot and verified that the performance and results are acceptable? As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
[ ] Does the query have an appropriate level of in-query comments/documentation?
[ ] Have you considered/identified possible edge cases?
[ ] Does the query not reinvent features in the standard library?
[ ] Can the query be simplified further (not golfed!)
Reviewer
[ ] Have all the relevant rule package description files been checked in?
[ ] Have you verified that the metadata properties of each new query is set appropriately?
[ ] Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
[ ] Are the alert messages properly formatted and consistent with the style guide?
[ ] Have you run the queries on OpenPilot and verified that the performance and results are acceptable? As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
[ ] Does the query have an appropriate level of in-query comments/documentation?
[ ] Have you considered/identified possible edge cases?
[ ] Does the query not reinvent features in the standard library?
[ ] Can the query be simplified further (not golfed!)
Description
PR #690 was merged last week despite having CodeQL compilation issues. This PR ensures the
Validate test resultsjob reportsfailurein the case that a dependent matrix job fails to execute (e.g. due to a CodeQL compilation error). Previously it reported "skipped", which was sufficient for the status check on the PR to pass and to allow it to be merged.This is achieved by ensuring the
Validate test resultsjob is always run, and then checking if therun-test-suitesjob failed to complete, and aborting early if it did.To test that the new approach works, I introduced a compilation failure in commit https://github.com/github/codeql-coding-standards/pull/712/commits/1651c1f30dda8df6f2e8553174b7e89fa1087886. This actions job shows the new approach correctly
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨 Reviewer: Confirm that format of shared queries (not the .qll file, the .ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.