github / codeql-coding-standards

This repository contains CodeQL queries and libraries which support various Coding Standards.
MIT License
129 stars 59 forks source link

Fix issue 755 and typo in A18-1-1 test #773

Closed fjatWbyT closed 6 days ago

fjatWbyT commented 1 month ago

Description

Fix issue #755 following suggestion therein.

Change request type

Rules with added or modified queries

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

🚨🚨🚨 Reviewer: Confirm that format of shared queries (not the .qll file, the .ql file that imports it) is valid by running them within VS Code.

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

Reviewer

fjatWbyT commented 1 week ago

For sure, @lcartey. Thank you for the review and asking for the test cases.