search

github / codeql

CodeQL: the libraries and queries that power security researchers around the world, as well as code scanning in GitHub Advanced Security
https://codeql.github.com
MIT License
7.48k stars 1.49k forks source link

LGTM.com - false positive #8803

Open Peter554 opened 2 years ago

Peter554 commented 2 years ago

https://lgtm.com/projects/g/Peter554/dc_schema/snapshot/1db0bf29e24a94849626e1c2818662278e3ae4c5/files/dc_schema/__init__.py?sort=name&dir=ASC&mode=heatmap#xe70d665ab5aefede:1

Keyword argument 'include_extras' is not a supported parameter name of function get_type_hints.

get_type_hints definitely has an argument include_extras in python 3.9 (which is the version of python i'm using). https://docs.python.org/3.9/library/typing.html#typing.get_type_hints

aeisenberg commented 2 years ago

Indeed, this looks like a false positive. Thank you for reporting it!

Our current focus is on improving our security analysis. Because your report does not relate to a security query, we will put this on our backlog and prioritize it if we get enough reports of the same underlying issue in other projects. If you think that your report is related to our security analysis, please clarify that in a comment. Either way, we'll let you know here as soon as it's fixed!

As you might know, all of our queries are open source. If you do have an idea for a code change, we encourage you to open a pull request. GitHub Code Scanning and lgtm.com have facilities for suppressing individual alerts or disabling a query.