search

github / codeql

CodeQL: the libraries and queries that power security researchers around the world, as well as code scanning in GitHub Advanced Security
https://codeql.github.com
MIT License
7.48k stars 1.49k forks source link

LGTM.com - false positive #9810

Open imalfect opened 2 years ago

imalfect commented 2 years ago

This route handler performs [authorization] but is not rate-limited, while it is.

The request is rate limited, while LGTM thinks it is not. As you see above the export there is a app.use('/api/createMerchant', payLimiter), and the payLimiter is created on the index.js file. URL to the alert on the project page on LGTM.com https://lgtm.com/projects/g/imalfect/VitePay/snapshot/af27317a55f197470a9a3145a6a75f4dcf5a92b0/files/src/routers/createAPIKey.js#xa7d8b094a3bcd4d5:1

aeisenberg commented 2 years ago

Indeed, this looks like a false positive. Thank you for reporting it!

Our current focus is on improving our security analysis. Because your report does not relate to a security query, we will put this on our backlog and prioritize it if we get enough reports of the same underlying issue in other projects. If you think that your report is related to our security analysis, please clarify that in a comment. Either way, we'll let you know here as soon as it's fixed!

As you might know, all of our queries are open source. If you do have an idea for a code change, we encourage you to open a pull request. GitHub Code Scanning and lgtm.com have facilities for suppressing individual alerts or disabling a query.