search

github / codespaces-jetbrains-feedback

Feedback on the Codespaces integration with JetBrains IDEs
Apache License 2.0
32 stars 7 forks source link

'C:\Program' is not recognized as an internal or external command, #64

Open Rjtsahu opened 1 year ago

Rjtsahu commented 1 year ago

Description Steps to reproduce Impact Additional context OS: Windows 11 OS Version: 10.0 OS Architecture: amd64 Java Version: 17.0.5 Java Runtime Version: 17.0.5+1-b653.23 Java Vendor: JetBrains s.r.o. Available CPUs: 16 Max Memory: 536870912 Free Memory: 37130736 Total Memory: 167772160 IDE Version: 2022.3.1 IDE: JetBrains Gateway 2022.3.1 Plugin Version: 0.3.0.971 Plugin path: C:\Users\Rajat Sahu\AppData\Roaming\JetBrains\JetBrainsGateway2022.3\plugins\github-codespaces-gateway Plugin ID: com.github.codespaces.jetbrains.gateway


![Screenshot_20221229_143040](https://user-images.githubusercontent.com/10388467/209928504-9be939bb-ed3b-4f98-b690-e8493ee86894.png)
AyeshaGagguturi commented 1 year ago

Hey @Rjtsahu , sorry you're running into issues. Thanks for the info. Would it be possible to update the description with the photo rendered.

Rjtsahu commented 1 year ago

This is happening when I am trying to connect my Github repo to Jetbrain gateway (on windows 11)

Screenshot_20221229_143040

erikaellr commented 1 year ago

@Rjtsahu Can you provide your repro steps? I haven't been able to repro this on Windows 11, using the same versions of the Gateway and Codespaces plugin.

I'm especially interested in:

Rindula commented 1 year ago

Hi @erikaellr,

I'm running into the same Problem here image

I installed gh via winget. It's installed under C:\Program Files\GitHub CLI

Where can I find the Codespace Settings?

I Connected through the Jetbrains Gateway, opening the Codespace, selecting PhpStorm there and clicked connect.

erikaellr commented 1 year ago

@Rindula You can get to Codespaces Settings two ways: 1) open Preferences in JetBrains Gateway, there should be an entry in the left nav for GitHub Codespaces, the GitHub CLI Path can be set explicitly there. 2) on Windows, control+shift+A will bring up the Actions search, and you can search for "Codespace", and click either "Codespace Settings" which will take you to the view of all settings, or "Codespaces: Manually Set GitHub CLI Path", which will allow you to enter the path to the CLI executable.

I tried again, but still can't repro this issue. When I install gh via winget, it gets installed under C:\Program Files\GitHub CLI, which is on my PATH, so the JetBrains Gateway Codespaces plugin finds gh automatically and can successfully use it to list codespaces and connect to codespaces. I also tried setting the "Codespaces: Manually Set GitHub CLI Path" action to explicitly set the path to gh, but if I set it correctly, listing codespaces and connecting still works, and if I set it incorrectly, the Codespaces list view won't even load successfully, so I am stumped as to how it might be possible to get Codespaces listed, but for it to fail with that error at connection. Sorry to not have been more help, we'd still love to hear any more detail you might be able to provide!

Rindula commented 1 year ago

Okay, i might know how to reproduce this.

First you install JetBrains Gateway and start it. Install the GitHub Codespaces extension and open it. You will be asked to install the gh-cli from there. leave it open and install the gh-cli (via winget in my case). Jetbrains Gateway will recognize the installation and allows you to proceed, but fails with this error in the next step.

After rebooting my PC this error does not occur anymore, so I think, there might be two or more methods to detect the gh-cli, one of them has an error in escaping characters.