github / codespaces-nextjs

124 stars 156 forks source link

Better support for non-x86-64 archs #2

Open myyk opened 1 year ago

myyk commented 1 year ago

Firstly, thanks for this awesome template! I'm pretty new to Next, so I'm sorry if this isn't a very good issue.

I believe that the mcr.microsoft.com/devcontainers/universal:2 image used in this template is only built for x86-64 arch according to https://github.com/microsoft/vscode-dev-containers/tree/main/containers/codespaces-linux. I'm guessing this is going to run into many performance issues for amd64 users like me on Apple silicon.

I found a simple change like this seems to at least work enough for a template: https://github.com/github/codespaces-nextjs/compare/main...myyk:codespaces-nextjs:patch-1 (pls excused the misleading comment on it and the bad formatting)

I don't know if there are other reasons why devcontainers/universal was used instead of devcontainers/typescript-node though.

RanaRabees commented 1 year ago

You Looks Right myyk