Closed ReubenJ closed 2 months ago
This is great! Thanks for adding!
I believe we also need to modify contributors.py where it has:
if start_date and end_date:
To have an else statement otherwise contributors will never be properly filled.
Oops! Ok this just isn't true. Contributors is calculated before the conditional so never mind.
Yeah—one more test case for contributors.py
probably wouldn't have hurt, but it does work with the fix! Thanks for the quick response.
Pull Request
Proposed Changes
Skip date validation when the respective environment variable is set. Currently, omitting the dates causes the action to fail, so it's impossible to output a report that does not include whether a user is a new contributor.
Readiness Checklist
Author/Contributor
make lint
and fix any issues that you have introducedmake test
and ensure you have test coverage for the lines you are introducing@jeffrey-luszcz
Reviewer
bug
,documentation
,enhancement
,infrastructure
,maintenance
orbreaking