github / docs

The open-source repo for docs.github.com
https://docs.github.com
Creative Commons Attribution 4.0 International
16.37k stars 59.9k forks source link

Use operationId for `#anchor` tags of REST API endpoint titles #139

Closed gr2m closed 2 years ago

gr2m commented 4 years ago

What feature or product is affected?

What is the new or expected behavior?

Example

https://docs.github.com/en/rest/reference/repos#check-if-vulnerability-alerts-are-enabled-for-a-repository

would become

https://docs.github.com/en/rest/reference/repos#check-vulnerability-alerts

See OpenAPI spec at https://github.com/github/openapi/blob/347c7c385184352692d4118b7e8a266ccf9b7db7/definitions/operations/repos/check-vulnerability-alerts.yml#L6

How is the old or inaccurate behavior currently documented?

n/a

Who does this affect?

Every change to an #anchor name for endpoint titles requires a change in the code, due to the error handlers which include a URL to the documentation. The endpoint titles are more prone to changes, while operation IDs should be changed much less frequently, as they are consider a breaking change to some of the OpenAPI consumers, while the "summary" key is not.

The problem with the title changes might also be amplified once translations are introduced.

@zeke sent me here, we shortly discussed it today:

image

What is the impact to users?

n/a

Content strategy and implementation

tbd

chiedo commented 4 years ago

Would making this change mean we'd be breaking anchor links people already have bookmarked and if so, are we OK with that?

chiedo commented 4 years ago

What level of effort would it take to make sure all of the old anchor URL as of today will redirect to the new URLs based on the operation ID when we make this change?

@zeke / @sarahs

zeke commented 4 years ago

I think we could pretty easily add invisible companion anchors to continue supporting the old slugs.

chiedo commented 4 years ago

The obvious idea. Good thinking. Let's do both! So the old ones still work. But make the Operation ID URLs the default for anything that links to those sections.

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 60 days with no activity.

chiedo commented 4 years ago

Still planning todo. Just taking time to get to it. Other priorities.

chiedo commented 4 years ago

@nschonni this one may be worth looking at if you decide to spend more time making improvements to the codebase!

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 60 days with no activity.

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 60 days with no activity.

SaultanBeagama commented 3 years ago

هل يعني إجراء هذا التغيير أننا سنكسر روابط الإرساء التي وضع الأشخاص إشارة مرجعية عليها بالفعل ، وإذا كان الأمر كذلك ، فهل نحن موافقون على ذلك؟

mohamaed530 commented 3 years ago

image

DiddiLeija commented 3 years ago

Hi everybody! As I can see, this issue is not resolved. Can I work on it?

heiskr commented 3 years ago

I suspect it would be fine to simply switch to using the "summary key" as long as there are no duplicates on any page. I don't think we need to add "invisible companion anchors" for the current hashes, I'm concerned about added complexity and maintenance doing that. We would be happy to have an open source contributor help with this task, as we will likely not prioritize this internally.

Mobibaba121 commented 2 years ago

Payment it

1alan91 commented 2 years ago

Park+

fastag1

cmwilson21 commented 2 years ago

👋 Thanks all for the feedback in this issue. I spoke with the team and we are going to work on this internally. So I'm going to go ahead and close this issue.

Thanks again! 💛