Closed thispsj closed 2 years ago
@thispsj Thanks so much for opening an issue! I'll triage this for the team to review :eyes:
Someone please add the codespaces
label also.
Hi @thispsj šš» - thanks for creating this issue āØ Just to let you know that I've asked the relevant team for a technical review on your observations and suggestions. Thanks for your patience š
Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert :eyes:
This is a gentle bump for the docs team that this issue is waiting for technical review.
@thispsj Do you think you'll get around to this at some point? We'd love to see the docs updated to avoid recommending our deprecated library.
@thispsj Do you think you'll get around to this at some point? We'd love to see the docs updated to avoid recommending our deprecated library.
@lgarron Ya sure I can implement this provided that I can edit REST docs. š
Thanks for opening this issue and for writing a replacement script @thispsj š As you noted, this needs to be fixed internally in the OpenAPI schema, so I will add a label to start that process.
Thank you for opening this issue! Updates to the REST/GraphQL API description must be made internally. I have copied your issue to an internal issue, so I will close this issue.
Code of Conduct
What article(s) on docs.github.com is/are affected?
Four articles :
1) * https://docs.github.com/rest/actions/secrets#create-or-update-an-organization-secret
What part(s) of the article would you like to see updated?
Some points which I would like to highlight here :
tweetsodium
the JS lib based on sodium maintained by GitHub is now no more maintained and updated. It has been marked deprecated in the latest release (i.e.0.0.6
).dists
folder which contained the scripts that contained all the functions. Therefore any user callingrequire('tweetsodium')
in their code would get an error thatindex.umd.js
is missing (as it was present in thedists
folder).tweetsodium
should migrate to some other sodium based library.libsodium-wrappers
which is also recommended bytweetsodium
authors as it is easy to use, opensource and by the same author who authored the C librarylibsodium
. (Source Code)libsodium-wrappers
(instead oftweetsodium
) which are given for encrypting the secrets with public key before they're sent over the API because currently those snippets will give errors.Additional information
I am also providing the replacement script below:
async/await
can also be used instead.UPDATE
REST API reference for codespaces secrets (both user and repository) is also affected and hence added.