search

github / docs

The open-source repo for docs.github.com
https://docs.github.com
Creative Commons Attribution 4.0 International
16.16k stars 59.41k forks source link

Documentation for generating a JWT uses relatively unknown Python library #33796

Closed altaurog closed 1 month ago

altaurog commented 3 months ago

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app#example-using-python-to-generate-a-jwt

What part(s) of the article would you like to see updated?

The python code relies on the jwt library, which is comparatively unknown. I think a better choice for github documentation is the more widely-recognized and used PyJWT library. The code would be more simple, and the library is more highly regarded:

library github stars libraries.io SourceRank snyk Package Health Score
jwt 137 18 58 / 100
PyJWT 4988 22 91 / 100

Additional information

No response

welcome[bot] commented 3 months ago

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

nguyenalex836 commented 3 months ago

@altaurog Thank you for opening an issue and linking it to your PR! ✨