Open jsoref opened 4 months ago
@jsoref Thanks for opening an issue! I'll get this triaged for review ✨
Thanks for raising this interesting question. My assumption is that when an organization publishes an action, it automatically inherits the profile image for that organization (for example, Snyk and Atlassian), but that you can override this default by defining branding.
You can see that the https://github.com/marketplace/actions/snyk-node action, created by someone outside the Snyk organization uses the Feather alert-circle
icon and that this is defined in the branding metadata for the action: https://github.com/awshole/snyk-node/blob/13b3b80f6e799f615fb8275464e69f04a7fa7057/action.yml#L4-L5.
In contrast, branding is undefined by this action released by the Snyk organization, see https://github.com/snyk/release-notes-preview/blob/master/action.yaml.
Before we add anything about this to the documentation, I'd like to get this confirmed by a subject matter expert.
Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert :eyes:
Hi @jsoref 👋
It turns out that we were almost right:
action.yml
file.We'll update the issue summary to suggest making the following docs changes:
branding
to override this avatar for actions published from user-owned repositories and for unverified actions published from organization-owned repositories.and add the help wanted
label, so that you or anyone else may submit a PR to make these changes 💛
@nguyenalex836: the bot attacked again
@nguyenalex836 / @felicitymay: I just created a test action without a branding
key and it didn't show the owner's icon:
advanced-security/component-detection-dependency-submission-action
branding:
icon: 'upload-cloud'
color: 'blue'
The action is listed on the marketplace: Component Detection dependency submission action
And appears to be a verified creator.
@jsoref Hmm, interesting! Let me circle back with our SME and see if they are aware of any recent changes - will return with more info 💛
Code of Conduct
What article on docs.github.com is affected?
https://docs.github.com/en/actions/creating-actions/publishing-actions-in-github-marketplace https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#branding
What part(s) of the article would you like to see updated?
branding
to override this avatar for actions published from user-owned repositories and for unverified actions published from organization-owned repositories.Additional information
https://docs.github.com/en/actions/creating-actions/publishing-actions-in-github-marketplace#about-badges-in-github-marketplace has pictures that show icons that are obviously not listed in https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#branding but there's nothing that explains how this works.