search

github / docs

The open-source repo for docs.github.com
https://docs.github.com
Creative Commons Attribution 4.0 International
16.13k stars 59.32k forks source link

Update `about-code-owners.md` #34699

Open daczarne opened 7 hours ago

daczarne commented 7 hours ago

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

What part(s) of the article would you like to see updated?

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file

Additional information

The wording might be interpreted incorrectly by users leading them to believe that statements like

/apps/github

will cause the ownership of that subfolder to revert back to a previously defined owner, when this is not the case.

welcome[bot] commented 7 hours ago

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

docs-bot commented 7 hours ago

This issue may have been opened accidentally. I'm going to close it now, but feel free to open a new issue with a more descriptive title!

nguyenalex836 commented 4 hours ago

@daczarne Apologies for our overzealous bot - thank you for opening an issue and linking it to your PR! ✨

daczarne commented 3 hours ago

@daczarne Apologies for our overzealous bot - thank you for opening an issue and linking it to your PR! ✨

No problem at all. Thanks for taking a look.

It was just a situation we ran into today at work. Several devs and we all interpreted the doc in the wrong. Thought this would be the best way of sharing our findings 😅