Improve OIDC JWT Retrieval Documentation

NeoCat commented 3 days ago

Why:

Closes: #35340

What's being changed (if available, include any code snippets, screenshots, or gifs):

This pull request addresses several issues in the current documentation for manually requesting a JSON Web Token (JWT) from the GitHub OIDC provider. The updates focus on improving clarity, security, and accuracy.

Changes:

Replaced incorrect environment variable name with proper reference to ACTIONS_ID_TOKEN_REQUEST_TOKEN.
Removed the direct logging of the retrieved JWT to avoid potential exposure in logs.
Simplified and clarified the example code by removing redundant node.js step and cleaned up the curl lines.

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
- For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
[x] For content changes, I have completed the self-review checklist.

welcome[bot] commented 3 days ago

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

github-actions[bot] commented 3 days ago

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.	Source	Preview	Production	What Changed
`actions/security-for-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-cloud-providers.md`	fpt br>[ghec](https://docs-35341-0ef138.preview.ghdocs.com/enterprise-cloud@latest/actions/security-for-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-cloud-providers)<brghes@ 3.15 3.14 3.13 3.12 3.11 3.10	fpt br>[ghec](https://docs.github.com/enterprise-cloud@latest/actions/security-for-github-actions/security-hardening-your-deployments/configuring-openid-connect-in-cloud-providers)<brghes@ 3.15 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

nguyenalex836 commented 2 days ago

@NeoCat Thanks so much for opening a PR! I'll get this triaged for review ✨

github-actions[bot] commented 2 days ago

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert :eyes:

Obada1989 commented 2 days ago

Your welcom

في الثلاثاء، ١٩ نوفمبر، ٢٠٢٤ ٦:٤٠ م github-actions[bot] < @.***> كتب:

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

— Reply to this email directly, view it on GitHub https://github.com/github/docs/pull/35341#issuecomment-2486217034, or unsubscribe https://github.com/notifications/unsubscribe-auth/BLLAYZFLEO3PV4I6HJGDDJT2BNSZPAVCNFSM6AAAAABSBDVZOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWGIYTOMBTGQ . You are receiving this because you commented.Message ID: @.***>

github / docs