github / docs

The open-source repo for docs.github.com
https://docs.github.com
Creative Commons Attribution 4.0 International
16.39k stars 59.95k forks source link

Blank lines causing the quote lines to not be joined to the "tip" formatted block. #35365

Closed Skenvy closed 1 day ago

Skenvy commented 2 days ago

Why:

The resulting markdown currently renders as an empty TIP block and a subsequent quote block. The goal of this is to join the disconnected quote block to the empty TIP block above it.

Closes: https://github.com/github/docs/issues/35364

What's being changed (if available, include any code snippets, screenshots, or gifs):

Duplicate the TIP block start into both branches of the conditional entry.

Old

image

New

image

Check off the following:

welcome[bot] commented 2 days ago

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

github-actions[bot] commented 2 days ago

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request. Source Preview Production What Changed
account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-your-personal-account/merging-multiple-personal-accounts.md fptbr>[ghec](https://docs-35365-38d1b7.preview.ghdocs.com/enterprise-cloud@latest/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-your-personal-account/merging-multiple-personal-accounts)<br fptbr>[ghec](https://docs.github.com/enterprise-cloud@latest/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-your-personal-account/merging-multiple-personal-accounts)<br

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

github-actions[bot] commented 1 day ago

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap: