github / docs

The open-source repo for docs.github.com
https://docs.github.com
Creative Commons Attribution 4.0 International
16.39k stars 59.95k forks source link

Fix note alert rendering #35368

Closed akordowski closed 1 day ago

akordowski commented 1 day ago

Why:

This PR provides a fix for a Note alert rendering in the this article.

grafik

Closes: none

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

akordowski commented 1 day ago

FYI: I run an check over the docs for further occurrences of alerts with if conditions that might brake the rendering of the alert. This was the only one left I could find.

github-actions[bot] commented 1 day ago

Automatically generated comment ℹī¸

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request. Source Preview Production What Changed
code-security/codeql-cli/getting-started-with-the-codeql-cli/about-the-codeql-cli.md fptbr>[ghec](https://docs-35368-b31819.preview.ghdocs.com/enterprise-cloud@latest/code-security/codeql-cli/getting-started-with-the-codeql-cli/about-the-codeql-cli)<brghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fptbr>[ghec](https://docs.github.com/enterprise-cloud@latest/code-security/codeql-cli/getting-started-with-the-codeql-cli/about-the-codeql-cli)<brghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable

fpt: Free, Pro, Team ghec: GitHub Enterprise Cloud ghes: GitHub Enterprise Server

nguyenalex836 commented 1 day ago

@akordowski Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏

github-actions[bot] commented 1 day ago

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues :zap: