github / docs

The open-source repo for docs.github.com
https://docs.github.com
Creative Commons Attribution 4.0 International
16.41k stars 60.01k forks source link

Align `danger` alert to match the markdown notation #35435

Closed akordowski closed 49 minutes ago

akordowski commented 1 day ago

Code of Conduct

What article on docs.github.com is affected?

Multiple articles.

What part(s) of the article would you like to see updated?

The articles

are using the \data\reusables\enterprise_clustering\proxy_xff_firewall_warning.md reusable to display the following alert:

grafik

and the article

has the following alert:

grafik

I would suggest to use the > [!CAUTION] markdown notation to align this alerts with other alerts (also as described here).

grafik

Additional information

I could provide a PR with a fix.

nguyenalex836 commented 19 hours ago

@akordowski I'm in agreement with you 💛 Feel free to open a PR whenever you have time!

akordowski commented 9 hours ago

@nguyenalex836 Here you can see the changes: