search

github / docs

The open-source repo for docs.github.com
https://docs.github.com
Creative Commons Attribution 4.0 International
16.36k stars 59.89k forks source link

"merged notification" workflow is being skipped #97

Closed zeke closed 4 years ago

zeke commented 4 years ago

We've had a few PRs land on this repo, but it appears none of them are getting comments after being merged to main.

https://github.com/github/docs/actions?query=workflow%3A.github%2Fworkflows%2Fmerged-notification.yml

I think this may be because of the conditional?

if: github.event.repository.private == false && github.event.pull_request.merged && github.event.pull_request.base.ref == github.event.repository.default_branch

cc @JasonEtco

JasonEtco commented 4 years ago

@zeke now that the repo is public, these workflows are running but failing! I opened https://github.com/github/docs/pull/183 to get that fixed.