Update react.js to turn `jsx-a11y/no-autofocus` off

github / eslint-plugin-github

An opinionated collection of ESLint rules used by GitHub.

MIT License

286 stars 51 forks source link

Update react.js to turn `jsx-a11y/no-autofocus` off #442

Closed khiga8 closed 1 year ago

khiga8 commented 1 year ago

This is a follow-up to Staff-only issue.

There are legitimate uses of autofocus. While autofocus can easily be misused, we want to rely on other tools like an axe rule to surface those issues rather than code linting. This PR makes it so we turn the jsx-a11y/no-autofocus rule which is on as part of the recommended rulesets, off by default.

accessibility-bot commented 1 year ago

:wave: Hello and thanks for pinging us! You've entered our first responder queue. An accessibility first responder will review this soon.

:computer: On PRs for our review: please provide a review environment with steps to validate, screenshots (with alt text), or videos demonstrating functionality we should be checking. This will help speed up our review and feedback cycle.
:warning: If this is urgent, please visit us in #accessibility on Slack and tag the first responder(s) listed in the channel topic.

dgreif commented 1 year ago

I've published v4.8.0 with this change. @khiga8 do you mind bumping the dependency in github/github?