search

github / eslint-plugin-github

An opinionated collection of ESLint rules used by GitHub.
MIT License
295 stars 54 forks source link

bump `prettier` and `eslint-plugin-prettier` to latest versions #457

Closed shiftkey closed 1 year ago

shiftkey commented 1 year ago

https://github.com/github/eslint-plugin-github/pull/456 updates prettier to v3.0.0 but based on a PR for a different project that only updates prettier I think there are downstream problems and we should ensure the eslint-plugin-prettier is also in sync:

[check:lint] > @actions/add-to-project@0.0.0 check:lint
[check:lint] > eslint .
[check:lint] 
[check:lint] 
[check:lint] Oops! Something went wrong! :(
[check:lint] 
[check:lint] ESLint: 8.44.0
[check:lint] 
[check:lint] TypeError: prettier.resolveConfig.sync is not a function
[check:lint] Occurred while linting /home/runner/work/add-to-project/add-to-project/__tests__/add-to-project.test.ts:1
[check:lint] Rule: "prettier/prettier"
[check:lint]     at Program (/home/runner/work/add-to-project/add-to-project/node_modules/eslint-plugin-prettier/eslint-plugin-prettier.js:138:40)
[check:lint]     at ruleErrorHandler (/home/runner/work/add-to-project/add-to-project/node_modules/eslint/lib/linter/linter.js:1050:28)
[check:lint]     at /home/runner/work/add-to-project/add-to-project/node_modules/eslint/lib/linter/safe-emitter.js:45:58
[check:lint]     at Array.forEach (<anonymous>)