github / eslint-plugin-github

An opinionated collection of ESLint rules used by GitHub.
MIT License
286 stars 51 forks source link

Provide `no-redundant-roles` exception for `rowgroup` #531

Closed khiga8 closed 3 weeks ago

khiga8 commented 3 weeks ago

Relates to: https://github.com/github/accessibility/issues/5304

Follow-up to: https://github.com/github/accessibility/discussions/4921

What

This PR adds an exception so that the no-redundant-roles rule does not flag redundant use of rowgroup for:

Why

There have been 3 reported instances of false positives raised by this rule. All of these relate to redundant usage of role="rowgroup". Redundant usage of role="rowgroup" is necessary in some cases to ensure that table semantics are not dropped by screen readers.

The reported instances are:

It seems appropriate to not flag redundant use of role="rowgroup" for now. We can always revisit this in the future.

Why don't we turn this rule off completely?

All the reported false positives are for role="rowgroup" which we can except, so it does not seem worth turning the rule off completely.

accessibility-bot commented 3 weeks ago

:wave: Hello and thanks for pinging us! You've entered our first responder queue. An accessibility first responder will review this soon.