search

github / gh-classroom

GitHub Classroom CLI Extension is a powerful and easy-to-use command line tool that enhances the functionality of the GitHub CLI, specifically tailored for educators using GitHub Classroom.
MIT License
83 stars 14 forks source link

Pending reviews are tied to indivudual so can not be shared among teachers before being submitted #11

Open jelmstrom opened 1 year ago

jelmstrom commented 1 year ago

When grading assignments the comments made by me as a teacher in a pending review are hidden from any other teachers that are involved in the course, meaning that it is hard to share workloads and collaborate on correction. it would be great if reviews are public to teachers, and can be submitted by anyone

shanep commented 1 year ago

Hi @jelmstrom I know this is issue is a bit old but can you be more specific? Are you talking about the pull requests that classrooms creates for you?

jelmstrom commented 1 year ago

Hi I think its even before that.

it appears that model that the classroom works on now is that its one teacher per class. We had several. What happens then is that each instructor starts their own review, which means you can not look at the suggestions other instructors have made. / Johan /

Den tis 26 sep. 2023 kl 15:24 skrev Shane K. Panter < @.***>:

Hi @jelmstrom https://github.com/jelmstrom I know this is issue is a bit old but can you be more specific? Are you talking about the pull requests that classrooms creates for you?

— Reply to this email directly, view it on GitHub https://github.com/github/gh-classroom/issues/11#issuecomment-1735537533, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH7I6JKVRQGRXG64KVISYDX4LJQPANCNFSM6AAAAAAZWWMZGI . You are receiving this because you were mentioned.Message ID: @.***>

shanep commented 1 year ago

Hi @jelmstrom if I am understanding you correctly regarding the feature you are using then yes, that is by design and how GitHub works. You have to submit your review for them to be visible to anyone else. From the docs step 9 :

Before you submit your review, your line comments are pending and only visible to you. You can edit pending comments anytime before you submit your review. To cancel a pending review, including all of its pending comments, click Review changes above the changed code, then click Cancel review.

One way around this limitation is to create a new account on GitHub that all teachers share to get around the limitation. That way everyone logs into the same account and everyone can see the pending reviews and you can divide up the workload offline.

Hopefully I understood your issue correctly and this helps your out:)

jelmstrom commented 1 year ago

Yes, thats what we discussed as well, but that approach was not so easy either, as we'd have to switch logged in accounts frequently to work on personal contributions to other repositories. If a pending review would be accessible to a team or a group of people, it would make life easier for teachers that are part of a group.

Regards

Johan.

Den tis 26 sep. 2023 kl 16:50 skrev Shane K. Panter < @.***>:

Hi @jelmstrom https://github.com/jelmstrom if I am understanding you correctly regarding the feature you are using then yes, that is by design and how GitHub works. You have to submit your review for them to be visible to anyone else. From the docs https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request step 9 :

Before you submit your review, your line comments are pending and only visible to you. You can edit pending comments anytime before you submit your review. To cancel a pending review, including all of its pending comments, click Review changes above the changed code, then click Cancel review.

One way around this limitation is to create a new account on GitHub that all teachers share to get around the limitation. That way everyone logs into the same account and everyone can see the pending reviews and you can divide up the workload offline.

Hopefully I understood your issue correctly and this helps your out:)

— Reply to this email directly, view it on GitHub https://github.com/github/gh-classroom/issues/11#issuecomment-1735702318, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH7I6LGPM2YIXOZVCR4RR3X4LTSPANCNFSM6AAAAAAZWWMZGI . You are receiving this because you were mentioned.Message ID: @.***>

shanep commented 1 year ago

Hi @jelmstrom, you are not alone regarding this feature :) You can read about the discussion regarding how reviews in the pending state can't be seen by anyone else or shared until they are submitted.

Unfortunately this feature is not a part of classrooms.github.com but of github itself.

-Shane