GitHub Classroom CLI Extension is a powerful and easy-to-use command line tool that enhances the functionality of the GitHub CLI, specifically tailored for educators using GitHub Classroom.
MIT License
75
stars
12
forks
source link
`pkg/classroom/http.go`: add test case for `GetAssignmentGrades` #32
This PR introduces a test case for GetAssignmentGrades defined in pkg/classroom/http.go to bring test coverage for this file to 100%.
As a way of getting to know this codebase better, I read through each of the files, compared the source code with the accompanying tests, and opened the targeted issue for tracking work. Once I got an understanding of how everything was set up, I modeled my changes based on what was already written.
For reviewers
Test mocks: to get this closer to what's in production, are there a better set of values for the assignment and starter code URLs?
Additional cases: do you all prefer that I add additional cases for when this endpoint returns an empty collection or if returns a non-200 status code? Please let me know and I can get to it!
Summary
Closes #31
This PR introduces a test case for
GetAssignmentGradesdefined inpkg/classroom/http.goto bring test coverage for this file to 100%.As a way of getting to know this codebase better, I read through each of the files, compared the source code with the accompanying tests, and opened the targeted issue for tracking work. Once I got an understanding of how everything was set up, I modeled my changes based on what was already written.
For reviewers
200status code? Please let me know and I can get to it!cc: @github/classroom-reviewers for review 👓