search

github / gh-classroom

GitHub Classroom CLI Extension is a powerful and easy-to-use command line tool that enhances the functionality of the GitHub CLI, specifically tailored for educators using GitHub Classroom.
MIT License
75 stars 12 forks source link

Missing repos #35

Closed ben-marlin closed 10 months ago

ben-marlin commented 10 months ago

I'm very new to GitHub Classroom, but I can't see where this issue has been addressed.

With gh classroom clone student-repos, I get 30 repos from a class of 56. Those that get cloned include some who have submitted and some who have not. Likewise with those which are missing.

Any idea what could be at fault?

shanep commented 10 months ago

Hi,

The downloader defaults to just 30. You can download more using the --per-page command line flag. With the example below we set the number of repos to download to 100 which should cover all your students :)

gh classroom clone student-repos --per-page 100

You can list all the options like this:

shane:classroom$ gh classroom clone student-repos --help        
Clone student repos for an assignment into a directory.

By default, the student repos are cloned into the current directory a directory named after the assignment slug. To clone into a different directory, use the --directory flag.

If the directory does not exists, it will be created.

Usage:
  classroom clone student-repos [flags]

Flags:
  -a, --assignment-id int   ID of the assignment
  -d, --directory string    Directory to clone into (default ".")
  -h, --help                help for student-repos
      --page int            Page number (default 1)
      --per-page int        Number of accepted assignments per page (default 30)
nuke-web3 commented 10 months ago

I (and every faculty member working with this tool) ran into this footgun as well - I would think a more sensible default be to do all students. Pages make no sense from the CLI - but do from the GUI, IMHO.

shanep commented 10 months ago

@NukeManDan I have a fix for this issue but I am currently blocked by issue #34 maybe @ryanhecht can help with getting this resolved?

shanep commented 10 months ago

Hi @NukeManDan and @ben-marlin I have summited a pull request #37 to address this. It seems to work on my end however if you would like to pull it down and test it out maybe that will help @RyanHecht merge it into main :)

shanep commented 10 months ago

@RyanHecht and @zrdaley With pr https://github.com/github/gh-classroom/pull/37 now merged on main can this issue be closed?

shanep commented 10 months ago

@NukeManDan and @ben-marlin https://github.com/github/gh-classroom/pull/37 was merged which allows you to clone all repos using gh classroom clone student-repos --all

You will need to pull in the latest release (v.0.1.9) first using gh extension upgrade classroom

ben-marlin commented 10 months ago

Thank you, friend!

Ben Marlin (he / him / his) Associate Professor, Chair of Mathematics Guilford College 5800 West Friendly Avenue Greensboro, North Carolina 27410

Office: Bauman 210H Phone: 336.316.2478 Fall 2023 Office Hours: Tuesday & Thursday 10:30-11:20 Monday & Friday 1:30-2:20 For Zoom appointments, consult my calendar https://calendar.google.com/calendar/u/0?cid=Ym1hcmxpbkBndWlsZm9yZC5lZHU and email a request.

On Tue, Sep 26, 2023 at 9:28 AM Shane K. Panter @.***> wrote:

@NukeManDan https://github.com/NukeManDan and @ben-marlin https://github.com/ben-marlin #37 https://github.com/github/gh-classroom/pull/37 was merged which allows you to clone all repos using gh classroom clone student-repos --all

You will need to pull in the latest release (v.0.1.9 https://github.com/github/gh-classroom/releases/tag/v0.1.9) first using gh extension upgrade classroom

— Reply to this email directly, view it on GitHub https://github.com/github/gh-classroom/issues/35#issuecomment-1735544583, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAP7NJSGFVA6WI5AARY4HLX4LJ7BANCNFSM6AAAAAA4MD2RCY . You are receiving this because you were mentioned.Message ID: @.***>

zrdaley commented 10 months ago

@shanep yes! thank you again for resolving this issue!