search

github / gh-classroom

GitHub Classroom CLI Extension is a powerful and easy-to-use command line tool that enhances the functionality of the GitHub CLI, specifically tailored for educators using GitHub Classroom.
MIT License
75 stars 12 forks source link

Implementation for issue #4 #37

Closed shanep closed 10 months ago

shanep commented 10 months ago

What are you trying to accomplish?

Implementation for issue #4

Downloading all the student repo is now the default behavior. All the original functionality such as downloading per page still exists. In almost all cases that I can think of an instructor or TA/LA wants all the assignments for a class so by default this feature is enabled and must be explicitly turned off to got back to the original.

What approach did you choose and why?

I added a new function and associated tests to get all the assignments. The new function simply calls the rest API in a loop until it receives no more input.

What should reviewers focus on?

I haven't written much go code so any feedback is appreciated :)

shanep commented 10 months ago

This also addresses issue #35

RyanHecht commented 10 months ago

Hi @shanep,

Thanks for this contribution! We agree that a single-command solution to downloading all student submissions is in the best interest for teachers. Our team is currently working on auditing the relevant API endpoints to ensure that we can scale with this new interface!