Open connorstorer-kbxcom opened 2 months ago
Also seeing similar behavior.
Wondering if this is the intended functionality & assumption that YAML pipelines would be using pr
within their yaml?
https://learn.microsoft.com/en-us/azure/devops/pipelines/yaml-schema/pr?view=azure-pipelines#remarks
I tested out adding the pr
section to the yaml file before rewiring the pipeline and got the same result :(
Here were the steps I followed:
pr
sectionI would expect it to still be overridden, but does a PR to github repo automatically kick off ADO pipeline?
EDIT: Oh nevermind, that should be default.
Description
After running the
rewire-pipeline
against an ADO YAML pipeline, the pipeline options/triggers have been changed unexpectedly. Curling the definition content it looks like therewire-pipeline
command removes the pipeline definitiontriggers
object and instead populates it withoptions
(mine didn't have options before anyway). After manually unchecking theOverride the YAML continuous integration trigger from here
checkbox and curling the definition, thetriggers
object is repopulated.After Running Command:![image](https://github.com/github/gh-gei/assets/141368382/9c353db4-7abc-4603-ac18-e59d223791cd)
After Manually Reverting/Unchecking:![image](https://github.com/github/gh-gei/assets/141368382/f6f1b385-7abd-43a5-bd24-51f2d185e1a2)
Reproduction Steps
Run the
rewire-pipeline
command against an ADO YAML pipeline without any explicit pipeline definition trigger overrides. After running the command, edit the pipeline in ADO and navigate to the triggers. Notice theOverride the YAML continuous integration trigger from here
checkbox is checked.