github / gh-gei

Migration CLI for GitHub to GitHub migrations
MIT License
327 stars 88 forks source link

Remove useGithubStorage from GHES version checker method #1295

Closed begonaguereca closed 1 week ago

begonaguereca commented 1 week ago

Closes https://github.ghe.com/github/octoshift/issues/9649!

This pull request simplifies the method calls to AreBlobCredentialsRequired by removing the boolean parameter that checks for gitHubOwnedStorage.

While this produces the correct result, it is confusing for a reader. This PR refactors out that logic and adds the checks in the correct spots.

github-actions[bot] commented 1 week ago

Unit Test Results

834 tests   834 ✅  23s ⏱️   1 suites    0 💤   1 files      0 ❌

Results for commit edf88707.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

Code Coverage

Package Line Rate Branch Rate Complexity Health
gei 80% 72% 554
ado2gh 84% 78% 627
Octoshift 87% 76% 1298
bbs2gh 79% 74% 680
Summary 84% (7039 / 8422) 76% (1597 / 2114) 3159