Open tambling opened 2 years ago
are we sure that it's always safe to retry when we get SERVICE_UNAVAILABLE? What if the migration was halfway through, then got a SERVICE_UNAVAILABLE. Does the migration clean up after itself before returning this error?
Edit: Nevermind, I see my questions were all answered in @synthead PR
We now have logic to retry all GraphQL reads in the case of a non-successful response, but there are still two issues (https://github.com/github/migration-friction/issues/689 and https://github.com/github/migration-friction/issues/701) that concern the
startRepositoryMigration
mutation. Since @synthead made the necessary change to the monolith to returnSERVICE_UNAVAILABLE
for mutations that have errored but are safe to retry, we should look for that status in the CLI to extend our retry to mutations (specificallystartRepositoryMigration
, which sends theSERVICE_UNAVAILABLE
error).Original comment from @synthead on #666 follows: