Closed Aashishkebab closed 2 years ago
@slenguyen Can we have this reviewed or get directed to someone who would? Thanks!
@ystndr Apologies, and thanks for the ping. Turns out I wasn't watching this repo, so I didn't get a notification on the PR. Fixed that!
I see we've added a dependency (minimist), and I wanted to check to see how that's being used -- or if that was just for debugging? Could I also trouble you to remove the console.log? Thanks!
Also: Thanks so much for the contribution!
@ystndr Apologies, and thanks for the ping. Turns out I wasn't watching this repo, so I didn't get a notification on the PR. Fixed that!
I see we've added a dependency (minimist), and I wanted to check to see how that's being used -- or if that was just for debugging? Could I also trouble you to remove the console.log? Thanks!
Also: Thanks so much for the contribution!
Mininist was auto added when I ran npm install
. I did not add it manually.
The console.log
shows useful information for the error. Otherwise, you don't get a useful error output. The "spinner" outputs this unusable image:
Whereas the console outputs this much more helpful one:
The Console output is the only reason we were able to figure out that the issue was a self-signed certificate, as "Server Side Error.itHub" doesn't really tell me what's wrong.
We were able to resolve it by disabling TLS temporarily.
Thanks for the details!
The
handleStatusError()
function doesn't take in the parameter for the exception itself, which is called "err".However, the function attempts to use "err" later on despite it not existing, causing a
ReferenceException
. This prevents the application from displaying the real error and instead shows that exception.Additionally, the
spinner.fail()
call does not display enough information to the user. I added aconsole.log()
so that the full exception is output.This fixes #8.