github / gh-net

A network bridge between a Codespace and a local machine.
https://github.com/github/gh-net
286 stars 22 forks source link

[ip-routing]: traffic is not routed to VPN if PTP virtual interface is configured as a default route #33

Closed legomushroom closed 2 years ago

legomushroom commented 2 years ago

If a point-to-point virtual network interface created by a VPN client has a single host in the interface subnet and is configured to be a default routing path, all traffic sent to such virtual network is dropped.

This comes from the fact that we drop traffic that is routed to default network interface and packet destination is not on the interface subnet because this case resemble "fallback" logic of the default route that sends any arbitrary traffic over.

The logic we have falls short for some of the VPN clients and needs to be improved to account for the PTP virtual network interface with conservative netmasks.

legomushroom commented 2 years ago

Fixed in 0.8.3 🎉