The string status has the character % after the progress percentage number. When printed once again using the Infof function, this % is read as a directive for formatting and ends up showing MISSING in the output as shown below:
A Pull Request should be associated with an Issue.
We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.
Description
The string
status
has the character%
after the progress percentage number. When printed once again using theInfof
function, this%
is read as a directive for formatting and ends up showingMISSING
in the output as shown below:Simply changing
Infof
toInfo
does not work here becausethis.migrationContext.Log
is an object of the typeDefaultLogger
in this repository, which uses the library https://github.com/outbrain/golib/log. That library uses formatting even when theInfo
function is called: https://github.com/outbrain/golib/blob/2531e5dbcc71b6f8a4ccf1205c209ae89b7529fc/log/log.go#L191-L193If this patch is not acceptible, then I can also just remove this line. The migration context logger prints the messages which are already printed to STDOUT once again to STDERR with the current time as a prefix. This change was introduced in the commit https://github.com/github/gh-ost/blob/515aa72d3d9b756e454b0168b4e57bc599b45e36/go/logic/migrator.go#L1039, introduced in the PR https://github.com/github/gh-ost/pull/1194.
A Pull Request should be associated with an Issue.
Related issue: https://github.com/github/gh-ost/issues/1373
script/cibuild
returns with no formatting errors, build errors or unit test errors.