search

github / gh-valet

Valet helps facilitate the migration of Azure DevOps, CircleCI, GitLab CI, Jenkins, and Travis CI pipelines to GitHub Actions.
MIT License
510 stars 35 forks source link

Add `--password-stdin` option to `gh valet update` #40

Closed ethanis closed 2 years ago

ethanis commented 2 years ago

Discussed in https://github.com/github/gh-valet/discussions/38

Originally posted by **korosuke613** May 26, 2022 `gh valet update` can specify `--password`, but this method is insecure. (I think this warning is issued by `docker login`.) ```console ❯ gh valet update --username korosuke613 --password *** WARNING! Using --password via the CLI is insecure. Use --password-stdin. ... ``` But, `gh-valet update` does not have the `--password-stdin` option. ```console ❯ gh valet update --username korosuke613 --password-stdin Unrecognized command or argument '--password-stdin'. ... ``` So I would like to see the `--password-stdin` option add to `gh valet update`. --- GitHub CLI version: 2.11.3 (2022-05-25) gh-valet version: v0.1.9