search

github / gh-valet

Valet helps facilitate the migration of Azure DevOps, CircleCI, GitLab CI, Jenkins, and Travis CI pipelines to GitHub Actions.
MIT License
510 stars 35 forks source link

Remove legacy prompts #80

Closed ethanis closed 2 years ago

ethanis commented 2 years ago

What's changing?

This updates the configure prompt to remove the *_SOURCE_GITHUB_(ACCESS_TOKEN|INSTANCE_URL) options as they are not needed for the vast majority of use cases. They can still be provided as environment variables or cli options, but we now default to reusing the values for GITHUB_ACCESS_TOKEN and GITHUB_INSTANCE_URL instead.

How's this tested?

$ dotnet run --project src/Valet/Valet.csproj -- configure
A new version of the Valet CLI is available. Run 'gh valet update' to update.
✔ Which CI providers are you configuring?: Jenkins
Enter the following values (leave empty to omit):
✔ GitHub handle used to authenticate with the GitHub Container Registry: 
✔ Personal access token to authenticate with the GitHub Container Registry: 
✔ Personal access token for GitHub: 
✔ Base url of the GitHub instance: https://github.com
✔ Personal access token for Jenkins: 
✔ Username of Jenkins user: 
✔ Base url of the Jenkins instance: 
Environment variables successfully updated.
github-actions[bot] commented 2 years ago

Unit Test Results

35 tests  ±0   35 :heavy_check_mark: ±0   0s :stopwatch: ±0s   1 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit 3a83c32b. ± Comparison against base commit 2447b9f6.