Closed luke-engle closed 2 years ago
35 testsβ Β±0βββ35 :heavy_check_mark: Β±0βββ0s :stopwatch: Β±0s ββ1 suites Β±0βββββ0 :zzz: Β±0β ββ1 filesββ Β±0βββββ0 :x: Β±0β
Results for commit e99732c5.βΒ± Comparison against base commit 57d429d9.
:recycle: This comment has been updated with latest results.
What's changing?
gh valet
was writing stdout and stderr to the console in parallel. This meant if there was an error that happened while we were writing to stdout, we got mangled text in the console. For example:WARNING! Your password will be stored unencLogin rypted in /home/codespace/.dockerSucceeded
.This change adds a lock to the
ReadStream
method to prevent both streams from writing at the same time.How's this tested?
Before this change π
After this change π
Closes #79