search

github / gh-valet

Valet helps facilitate the migration of Azure DevOps, CircleCI, GitLab CI, Jenkins, and Travis CI pipelines to GitHub Actions.
MIT License
510 stars 35 forks source link

Support darwin-arm64 #94

Closed alexelent-carta closed 1 year ago

luke-engle commented 1 year ago

Hi @alexelent-carta 👋

Could you give a bit more context here? I'm currently using the darwin-arm64 architecture (Apple M1 max) as well, and while I do get a warning when running gh valet on my machine, valet still functions properly. Is this what you're seeing as well, or are you seeing something different?

➜ gh valet forecast jenkins -o tmp
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
[2022-11-02 18:14:30] Logs: 'tmp/log/valet-20221102-181430.log'
alexelent-carta commented 1 year ago

Yeah, I don't see that warning. I get an error.

alexelent@Alex ~ % gh extension install github/gh-valet
gh-valet unsupported for darwin-arm64. Open an issue: `gh issue create -R github/gh-valet -t'Support darwin-arm64'`
alexelent@Alex ~ % echo $?
1
luke-engle commented 1 year ago

Oh interesting.. What version of gh are you using? (gh --version)

alexelent-carta commented 1 year ago 
gh version 2.4.0 (2021-12-21)
https://github.com/cli/cli/releases/tag/v2.4.0
alexelent-carta commented 1 year ago

Sigh... I figured out the issue. I am using brew. I had HOMEBREW_NO_AUTO_UPDATE=1 so it didn't install latest. So sorry.

luke-engle commented 1 year ago

Got it, no problem! After installing the latest, are you still seeing the error?

alexelent-carta commented 1 year ago

Nope, error is gone on latest version of gh cli (2.18.1)